build: reformat repo to new clang@1.4.0 #36628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
action: merge
This comment has been minimized.
This comment has been minimized.
pullapprove
bot
requested review from
alxhub,
AndrewKushnir,
andrewseguin,
atscott,
gkalpak,
JiaLiPassion and
matsko
|
Caretaker: The lint failure is caused because the change is too large for gulpLint to process. |
IgorMinar
removed request for
matsko,
atscott,
JiaLiPassion,
kara,
alxhub,
gkalpak,
andrewseguin and
AndrewKushnir
pullapprove
bot
requested review from
alxhub,
AndrewKushnir,
andrewseguin and
atscott
pullapprove
bot
requested review from
gkalpak,
JiaLiPassion,
JoostK,
matsko,
alxhub,
AndrewKushnir,
andrewseguin and
atscott
IgorMinar
approved these changes
Apr 14, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to clang-format@1.4.0 would bring angular/angular to the latest available version of clang-format and include support for newer ts/js features like the ones noted in the background section. However because the previous version of the clang-format the angular/angular repository was pinned to, 1.0.41, was nearly 4 years old the number of styling changes made by the formatter was greater than desired. After running the new version of clang-format across the formatted code in angular/angular it was found that ~2500 files would be affected by the new formatting. At the time, the presumption was this was too large of a single change to land and instead the change would need to be able to be rolled out incrementally.
The gulp tasks which run the formatter were updated to only format files which were found to be changed between the current HEAD of a ref and its previous HEAD. This works out to be either all of the changes in a single PR being looked at, or all of the changes in a commit as it lands in a branch. This allowed for the updated formatting to only happen in files already changed by a PR, rather than changing all ~2500 files in one change and invalidating nearly every outstanding PR.
However it was found that this created more noise than expected in each PR and instead our best action was to reformat the remaining formatted files in the repo in a single commit.
Patch version of #36613